Chore: update row test bc redshift now uses CTAS#5344
Merged
Conversation
treysp
force-pushed
the
trey/redshift-rows
branch
from
ba6fb18 to
2b6216b
Compare
erindru
approved these changes
Sep 10, 2025
erindru
left a comment
erindru
left a comment
Collaborator
There was a problem hiding this comment.
I think you've managed to trigger an unrelated flakey test:
FAILED tests/core/test_test.py::test_freeze_time_concurrent - assert 29 == 30
georgesittas
approved these changes
Sep 11, 2025
treysp
force-pushed
the
trey/redshift-rows
branch
from
2b6216b to
053b4cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redshift full models now use CTAS, for which the redshift cursor doesn't track rows inserted